Repository navigation
Click in the IDE: focus panes, select tree entries, place the caret (v1.68.0) - #147
Merged
Merged
Conversation
…v1.68.0) The decoder now reports a left-button press as KeyType.click (releases, drags and other buttons stay dropped). The IDE routes it to the pane under the pointer: the tree is focused and the row selected, with a double-click on the same row acting like Enter; the editor is focused and the caret moved to the clicked cell (EditorView.positionAt mirrors the gutter and scroll layout); a dock panel is focused. Like the wheel, clicks are ignored under a modal and never clear a message or disarm Ctrl-Q/Ctrl-W. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Any input other than a click breaks a pending double-click, so a key, wheel step or dialog between two clicks can no longer re-run Enter on a row whose content changed. - Ignore the extra mouse buttons (bit 128: back/forward), which decoded as left clicks. - EditorView.positionAt maps the clicked rune to a UTF-16 column, so a click never lands inside an emoji's surrogate pair; a click below the last line goes to the end of the file. - IdeApp takes an optional clock for double-click timing; tests now drive the 400 ms window deterministically. - Share one _paneAt hit-test between the wheel and the click; route through KeyEvent.isMouse. - Clicking a tab switches to it (TabBar.tabAt shares render's layout). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyType.clickfor a left-button press (SGR and legacy); releases, drags, middle/right buttons stay dropped.EditorView.positionAt(shares the gutter/scroll layout withrender); clamped past line/file end; binary files only focus.Test plan
dart analyzeclean🤖 Generated with Claude Code